feat: Add optional diagnostics hook - #29
Merged
Merged
Conversation
jsumners-nr
reviewed
May 26, 2026
jsumners-nr
left a comment
Contributor
There was a problem hiding this comment.
This usage definitely makes me wonder if the resolved install directory should be included with the specifier.
Member
Author
|
I just changed this to a hook. The first argument is the |
jsumners-nr
reviewed
May 26, 2026
Member
Author
|
The hook now takes an object and I've included |
jsumners-nr
reviewed
May 26, 2026
getTransformedModules for diagnostics
Member
Author
|
I should probably add a test for this! |
Contributor
Maybe. Could be useful. Who's to say? 😂 |
Member
Author
|
The new test passes once I updated to the the latest Orchestrion! |
jsumners-nr
approved these changes
May 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is dependent on this PR:
moduleNameandfilePathnodejs/orchestrion-js#74A diagnostics hook can be set which is called every time a module is transformed
or transformation fails. This hook will only work with the synchronous
registerHooksbecause the olderregisterhook runs in a different thread.