Skip to content

fix: Another TypeScript issue - #45

Merged
timfish merged 1 commit into
mainfrom
fix/further-typescript-issues
Jul 27, 2026
Merged

fix: Another TypeScript issue#45
timfish merged 1 commit into
mainfrom
fix/further-typescript-issues

Conversation

@timfish

@timfish timfish commented Jul 27, 2026

Copy link
Copy Markdown
Member

TS 3.8 cannot parse mixed type imports

@timfish
timfish requested a review from Lms24 July 27, 2026 10:26
@timfish
timfish enabled auto-merge (squash) July 27, 2026 10:29
@timfish
timfish disabled auto-merge July 27, 2026 10:29
@timfish
timfish merged commit 3ad7d6e into main Jul 27, 2026
1 check passed
@timfish
timfish deleted the fix/further-typescript-issues branch July 27, 2026 10:29
@timfish timfish mentioned this pull request Jul 27, 2026
andreiborza added a commit to getsentry/sentry-javascript that referenced this pull request Jul 27, 2026
…22676)

## What

Bump `@apm-js-collab/code-transformer-bundler-plugins` from `^0.7.1` to
`^0.7.3` in `@sentry/server-utils` and `@sentry/bun`, walking back the
pin from #22497.

* `packages/server-utils/package.json`: `^0.7.1` -> `^0.7.3`
* `packages/bun/package.json`: `^0.7.1` -> `^0.7.3`
* `yarn.lock`: resolves to 0.7.3

## Why

#22497 pinned to 0.7.1 to work around the
`generic-ts3.8` e2e test (0.7.2 shipped `.d.cts`/`.d.mts` files TS 3.8
could not parse). But 0.7.1's `.d.cts` has a broken
`./instrumentation-serde` re-export, which breaks modern TypeScript in
consumers.

0.7.3 was released upstream specifically for
[apm-js-collab/code-transformer-bundler-plugins#45](<apm-js-collab/code-transformer-bundler-plugins#45>)
("TS 3.8 cannot parse mixed type imports"). It moves to plain `.d.ts`
files with a resolvable `./instrumentation-serde.js` re-export, fixing
both sides: modern TS resolves the module, and TS 3.8 no longer chokes
on the type-import syntax.

Fixes #22626 <br>Fixes
#22646

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant