Add comment specifing normalized echo values unless documented otherwise - #45
Draft
rolker wants to merge 1 commit into
Draft
Add comment specifing normalized echo values unless documented otherwise#45rolker wants to merge 1 commit into
rolker wants to merge 1 commit into
Conversation
rolker
marked this pull request as draft
July 25, 2023 12:00
rolker
marked this pull request as ready for review
February 13, 2024 15:16
rolker
marked this pull request as draft
February 27, 2024 13:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A collaborator looking at the RadarEcho message recomended that echo values should be normalized. I mostly agree but want to keep the option open for radars that might have a good reason to report unnormalized values. A future RadarInfo type message could be used to report such a use.