Make release splunk_versions required (drop unsafe fleet default) - #5
Merged
Conversation
The `splunk_versions` input in the reusable release.yml defaulted to "9.0,9.1,9.2,9.3,9.4". That default was unsafe as a fleet-wide value: it declared Splunkbase compatibility with Splunk 9.0/9.1 (which ship Python 3.7) and omitted all 10.x releases, so a caller that relied on the default would silently claim an incorrect support matrix. Make the input `required: true` with no default so every caller must declare its own real, validated compatibility explicitly, and expand the description to explain why. Existing callers (apius_lang_entropy, the splunk-app-template caller) already pass splunk_versions, so this is a no-op for them and a guardrail for future apps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reusable
release.ymlsplunk_versionsinput defaulted to"9.0,9.1,9.2,9.3,9.4". As a fleet-wide default this is unsafe: it declares Splunkbase compatibility with Splunk 9.0/9.1 (which ship Python 3.7) and omits all 10.x releases, so any caller relying on the default would silently publish an incorrect support matrix.Change
splunk_versionsis nowrequired: truewith no default.Impact
No-op for existing callers —
apius_lang_entropyand thesplunk-app-templatecaller both already passsplunk_versionsexplicitly. This is a guardrail for future apps.