Build package before AppInspect so it inspects a tarball - #1
Merged
Conversation
The appinspect-cli-action globs app_path/* and expects the first entry to be a .tar.gz package. Passing the app source directory made it grab the first subdirectory and abort with 'Unable to locate package'. Fetch the packaging tooling, build a placeholder (0.0.0) package into dist/, and point AppInspect at dist/ so it inspects the tarball.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The AppInspect step passed
app_path: ${{ inputs.app_id }}(the app source directory). Thesplunk/appinspect-cli-action@v2.13.0entrypoint globsapp_path/*and takes the first entry, expecting a.tar.gz. Given the source dir it grabbed the first subdirectory (e.g.appserver) and aborted with "Unable to locate package ... aborting".Fix
Before AppInspect:
.splunk-app-ci(this repo is public, no token needed).dist/withPYTHONPATH=.splunk-app-ci python -m splunk_app_ci package --app-dir <app_id> --version 0.0.0 --dest dist. Version0.0.0is a non-release placeholder; the tarball exists only for inspection.app_path: distso the action globs the single tarball.excluded_tags: manual,result_file, and the artifact upload are unchanged.All other steps (ruff lint/format, tests) are unchanged. YAML validated with
yaml.safe_load. Package build verified locally against theapius_lang_entropyapp dir, producing a singleapius_lang_entropy-0.0.0.tar.gz.