Declare python.required for Splunk 10.2+ compatibility - #9
Merged
Conversation
AppInspect flags commands.conf/restmap.conf as future_failures because python.version is deprecated in Splunk 10.2+. Add python.required = 3.9 alongside the existing python.version = python3 (kept for 9.2-10.1, which don't read python.required). Clears check_commands_conf_python_required and check_script_restmap_conf_python_required; enables declaring 10.2-10.5 compat.
The reusable release workflow's splunk_versions default (9.0,9.1,9.2,9.3,9.4) is wrong for this app: it includes unsupported 9.0/9.1 (Python 3.7) and omits 10.x. Pass the correct list (9.2-10.5) so the automated Splunkbase upload declares accurate compatibility. 10.2-10.5 are valid given the python.required addition in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the two AppInspect
future_failures (issue apius-tech/splunk-app-standards#11).python.required = 3.9tocommands.conf [entropy]and bothrestmap.conf [script:*]stanzas.python.version = python3for Splunk 9.2-10.1 (which don't readpython.required);python.requiredis what Splunk 10.2+ uses (python.versionis deprecated there).Enables declaring 10.2-10.5 compatibility on the next Splunkbase release. Full clearance of the future_failures is confirmed by the AppInspect API on the next release (1.0.2).