Slice 6: pass splunkbase_app_id to reusable release workflow - #8
Merged
Conversation
Wires this app into the gated Splunkbase publish added in slice #6 (ADR-0006): - Forward splunkbase_app_id: ${{ vars.SPLUNKBASE_APP_ID }} to the reusable release workflow. The SPLUNKBASE_APP_ID repo variable is already provisioned (=9192); if it were unset the reusable workflow would skip the publish. - Keep `secrets: inherit` so SPLUNK_USER/SPLUNK_PASS reach the publish job; they are scoped to the `splunkbase` Environment, whose required reviewer is the manual approval gate. No behaviour change to packaging, AppInspect, or the GitHub Release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires this app into the gated Splunkbase publish added in apius-tech/splunk-app-ci#4 (issue apius-tech/splunk-app-standards#6, ADR-0006).
Changes (release.yml only)
splunkbase_app_id: ${{ vars.SPLUNKBASE_APP_ID }}to the reusable release workflow.SPLUNKBASE_APP_IDis already provisioned as a repo variable (=9192); if it were unset the reusable workflow would skip the Splunkbase publish.secrets: inheritsoSPLUNK_USER/SPLUNK_PASSreach the publish job; they are scoped to thesplunkbaseEnvironment, whose required reviewer is the manual approval gate.No change to packaging, AppInspect, or the GitHub Release.
Verification
yaml.safe_loadpasses.1.0.2release later.Depends on apius-tech/splunk-app-ci#4 (the reusable workflow must gain the
splunkbase_app_idinput first).