Skip to content

Added PHP 8.4 support#478

Merged
shailesh-google merged 2 commits into
apigee:3.xfrom
shailesh-google:issue-469-3.x
Jun 12, 2026
Merged

Added PHP 8.4 support#478
shailesh-google merged 2 commits into
apigee:3.xfrom
shailesh-google:issue-469-3.x

Conversation

@shailesh-google

@shailesh-google shailesh-google commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Fix: #469

  1. setAccessible(true) Method is deprecated Refer Here:- https://www.php.net/manual/en/reflectionproperty.setaccessible.php

  2. Added AMP Library Due to Error with lowest version test in composer analyze command.

  3. Psalm Error levels: https://psalm.dev/docs/running_psalm/error_levels/

@shailesh-google shailesh-google requested review from divya-intelli and shishir-intelli and removed request for shishir-intelli June 12, 2026 05:12
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.50575% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.63%. Comparing base (8022eba) to head (2a24d6b).

Files with missing lines Patch % Lines
...c/Api/ApigeeX/Controller/PaginationHelperTrait.php 50.00% 8 Missing ⚠️
src/Api/ApigeeX/Controller/RatePlanController.php 0.00% 1 Missing ⚠️
...Api/Monetization/Controller/RatePlanController.php 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x     #478      +/-   ##
============================================
- Coverage     86.64%   86.63%   -0.01%     
- Complexity     1773     1798      +25     
============================================
  Files           349      349              
  Lines          4664     4661       -3     
============================================
- Hits           4041     4038       -3     
  Misses          623      623              
Flag Coverage Δ
unittests 86.63% <88.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../ApigeeX/Controller/AcceptedRatePlanController.php 86.48% <100.00%> (ø)
...rc/Api/ApigeeX/Controller/ApiProductController.php 80.00% <100.00%> (ø)
...pi/ApigeeX/Controller/PrepaidBalanceController.php 100.00% <ø> (ø)
...geeX/Denormalizer/AcceptedRatePlanDenormalizer.php 85.71% <100.00%> (ø)
...pi/ApigeeX/Denormalizer/ApiProductDenormalizer.php 100.00% <100.00%> (ø)
src/Api/ApigeeX/Denormalizer/AppDenormalizer.php 73.33% <100.00%> (ø)
...i/ApigeeX/Denormalizer/BillingTypeDenormalizer.php 85.71% <100.00%> (ø)
...pigeeX/Denormalizer/PrepaidBalanceDenormalizer.php 85.71% <100.00%> (ø)
.../Api/ApigeeX/Denormalizer/RatePlanDenormalizer.php 90.00% <100.00%> (ø)
...igeeX/Denormalizer/RatePlanDenormalizerFactory.php 100.00% <ø> (ø)
... and 34 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shishir-intelli shishir-intelli left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shailesh-google shailesh-google merged commit fa185d9 into apigee:3.x Jun 12, 2026
8 checks passed
@shailesh-google shailesh-google added this to the 3.0.13 milestone Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants