Remove deprecated interactive shell command#270
Merged
Conversation
Removes `mcpc shell @<session>` and `mcpc @<session> shell` (deprecated in 0.3.1) along with the code only the shell consumed: - src/cli/shell.ts, src/cli/shell-parser.ts, and their unit test - bridge-to-CLI notification broadcast over IPC (the shell was its only consumer): broadcastNotification, the 'notification' IpcMessage type, BridgeClient/SessionClient forwarding, NotificationData/NotificationType - SessionClient no longer extends EventEmitter - Server log messages (notifications/message) are now recorded in the bridge log (mcpc @<session> logs) instead of being broadcast to now-nonexistent shell clients https://claude.ai/code/session_01KRtoViAeqzZbKRRy4mFGHU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the interactive
shellcommand (mcpc shell @<session>andmcpc @<session> shell), deprecated in 0.3.1 — run individualmcpc @<session> <command>invocations instead. Also strips out the code that existed only for the shell, cutting ~750 lines.src/cli/shell.ts,src/cli/shell-parser.ts, both command registrations, and the shell's unit/e2e testsSessionClientno longer extendsEventEmitternotifications/message) are now recorded in the bridge log (mcpc @<session> logs) instead of being broadcast to shell clientsRefs #243
https://claude.ai/code/session_01KRtoViAeqzZbKRRy4mFGHU