Skip to content

fix: reject zero screen dimensions in record schema#553

Closed
DoView1 wants to merge 1 commit into
apify:masterfrom
DoView1:codex/reject-zero-screen-dimensions
Closed

fix: reject zero screen dimensions in record schema#553
DoView1 wants to merge 1 commit into
apify:masterfrom
DoView1:codex/reject-zero-screen-dimensions

Conversation

@DoView1

@DoView1 DoView1 commented May 30, 2026

Copy link
Copy Markdown

Fixes #6

@algora-pbc /claim #6

Summary

  • Reject zero clientWidth, clientHeight, innerWidth, and innerHeight values in the generator record schema.
  • Keep valid zero offset values accepted, such as availLeft, pageXOffset, pageYOffset, and screenX.
  • Add regression coverage for zero dimensions and zero offsets.

Testing

  • npm exec --yes pnpm@10.33.4 -- vitest run test/generator-networks-creator/record-schema.test.ts
  • npm exec --yes pnpm@10.33.4 -- vitest run test/generator-networks-creator/generator-networks-creator.test.ts
  • npm exec --yes pnpm@10.33.4 -- lint
  • npm exec --yes pnpm@10.33.4 -- vitest run

@barjin

barjin commented Jun 2, 2026

Copy link
Copy Markdown
Member

See #544 (comment). Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show results masking fingerprint when test in pixelscan

4 participants