Skip to content

fix(generator-networks-creator): repair zero viewport dimensions before training#550

Closed
sk8kpwhrjt-creator wants to merge 1 commit into
apify:masterfrom
sk8kpwhrjt-creator:codex/fix-screen-dimensions-in-netgen
Closed

fix(generator-networks-creator): repair zero viewport dimensions before training#550
sk8kpwhrjt-creator wants to merge 1 commit into
apify:masterfrom
sk8kpwhrjt-creator:codex/fix-screen-dimensions-in-netgen

Conversation

@sk8kpwhrjt-creator

Copy link
Copy Markdown

Addresses #6.

@algora-pbc /claim #6

Summary

This follows the review feedback on #544 and #549 by keeping the fix out of runtime generation and out of the zod schema rejection path.

The patch repairs zero viewport dimensions in collected fingerprint records before they are deconstructed into the fingerprint training dataset:

  • infer zero innerWidth / innerHeight from the same record's screen, available screen, and outer window dimensions
  • infer zero clientWidth / clientHeight from the repaired inner viewport dimensions
  • preserve already collected positive viewport/client values unchanged
  • drop only fingerprint records that still contain unrepaired zero viewport dimensions after the repair step

That prevents future fingerprint networks from learning the innerWidth: 0, innerHeight: 0, clientWidth: 0, clientHeight: 0 shape reported in #6 without rejecting the bulk of the existing corpus.

Validation

  • pnpm exec vitest run test/generator-networks-creator/screen-viewport.test.ts test/generator-networks-creator/generator-networks-creator.test.ts
  • pnpm exec tsc --noEmit -p tsconfig.json
  • pnpm exec prettier --check packages/generator-networks-creator/src/generator-networks-creator.ts packages/generator-networks-creator/src/screen-viewport.ts test/generator-networks-creator/screen-viewport.test.ts
  • pnpm --filter generator-networks-creator compile
  • pnpm --filter generative-bayesian-network compile
  • git diff --check

@barjin

barjin commented May 22, 2026

Copy link
Copy Markdown
Member

See #549 (review)

@barjin barjin closed this May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants