fix: avoid read-only srcdoc assignment in iframe hook#547
Merged
Conversation
barjin
approved these changes
May 20, 2026
barjin
left a comment
Member
There was a problem hiding this comment.
Looks alright to me.
Thank you for the test!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the iframe
srcdochook infixIframeContentWindow()so assigningiframe.srcdocpreserves the assigned value instead of leaving the iframe withoutsrcdoccontent.What changed
contentWindowfix, assignsiframe.srcdoc, and checks both the DOM attribute and property value.srcdocsetter to store the assigned string on the final descriptor and write it withsetAttribute()instead of assigning to the now non-writable property.Why
The previous hook reset
srcdocas a non-writable own property with the original value, then immediately assigned through_iframe.srcdoc. In Chromium this left thesrcdocattribute unset, and in strict contexts it can throwCannot assign to read only property 'srcdoc'as described in #546.Testing
pnpm install --frozen-lockfilepnpm exec playwright install chromiumpnpm exec vitest run test/fingerprint-injector/fingerprint-injector.test.ts -t "srcdoc"(failed before the fix:srcdocattribute wasnull)pnpm exec vitest run test/fingerprint-injector/fingerprint-injector.test.ts -t "srcdoc"pnpm buildpnpm lint(passes with existingno-consolewarnings)git diff --checkFixes #546
Note: I used Codex to inspect the code path and draft the focused regression test, then reviewed the final diff and ran the listed verification commands locally.