feat: Add an afterCommit context helper - #4110
Open
janbuchar wants to merge 1 commit into
Open
Conversation
janbuchar
commented
Sep 7, 2026
janbuchar
commented
Contributor
- closes Storage write errors are no longer catchable, and there's no commit hook #4065
- Adds a new context helper that fires both when a storage transaction is committed successfully and when it throws an error
janbuchar
added
the
t-tooling
janbuchar
requested review from
B4nan,
barjin,
nikitachapovskii-dev and
vladfrangu
September 7, 2026 14:36
github-actions
Bot
added
the
tested
barjin
approved these changes
Sep 8, 2026
barjin
left a comment
barjin
left a comment
Member
There was a problem hiding this comment.
Thank you @janbuchar , just one thing ⬇️ (probably just the matter of documenting this better).
Comment on lines
+205
to
+207
| * if (error) { | ||
| * throw new NonRetryableError('The page is too big to store', { cause: error }); | ||
| * } |
Member
There was a problem hiding this comment.
If we throw a retriable error, does it mean we'll process the same request again? meaning
- run
requestHandler - commit dataset writes
- throw from
afterStorageCommit - (?) back to 1. and 2., creating duplicate dataset items?
Should we make every afterStorageCommit error non-retriable? Or maybe just document this better?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.