Skip to content

test: Remove --no-prompt flag from Apify CLI push command in E2E tests - #3183

Merged
B4nan merged 2 commits into
masterfrom
copilot/fix-97072506-35d8-43ab-8f9d-465e6797c7e8
Sep 30, 2025
Merged

test: Remove --no-prompt flag from Apify CLI push command in E2E tests#3183
B4nan merged 2 commits into
masterfrom
copilot/fix-97072506-35d8-43ab-8f9d-465e6797c7e8

Conversation

Copilot AI commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Changes

Removed the --no-prompt flag from the apify-cli@beta push command in the E2E test suite (test/e2e/tools.mjs).

Why

The --no-prompt flag is no longer necessary because:

  1. The Apify CLI is already authenticated in the GitHub workflow before E2E tests run (via npx -y apify-cli@beta login -t in .github/workflows/test-e2e.yml)
  2. With proper authentication in place, the CLI won't prompt for user input during the push operation
  3. This simplifies the command and aligns with the standard CLI usage pattern

Impact

This change only affects E2E tests running with STORAGE_IMPLEMENTATION=PLATFORM, where actors are pushed to the Apify platform for testing. The behavior remains the same since authentication is handled at the workflow level.

Modified file: test/e2e/tools.mjs

  • Changed: execSync('npx -y apify-cli@beta push --no-prompt', { cwd: dirName });
  • To: execSync('npx -y apify-cli@beta push', { cwd: dirName });
Original prompt

remo --no-prompt flag from the Apify CLI calls in E2E tests (its a workflow)


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: B4nan <615580+B4nan@users.noreply.github.com>
Copilot AI changed the title [WIP] remo --no-prompt flag from the Apify CLI calls in E2E tests (its a workflow) Remove --no-prompt flag from Apify CLI push command in E2E tests Sep 30, 2025
Copilot AI requested a review from B4nan September 30, 2025 07:56
@B4nan B4nan changed the title Remove --no-prompt flag from Apify CLI push command in E2E tests test: Remove --no-prompt flag from Apify CLI push command in E2E tests Sep 30, 2025
@B4nan
B4nan marked this pull request as ready for review September 30, 2025 07:57
@B4nan
B4nan merged commit 8c8e1f4 into master Sep 30, 2025
20 of 23 checks passed
@B4nan
B4nan deleted the copilot/fix-97072506-35d8-43ab-8f9d-465e6797c7e8 branch September 30, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants