fix: handle null values in enum allowedValues - #30
Merged
Conversation
When a schema defines a nullable enum (e.g., `enum: ['one', 'two', null]`), the `allowedValues` array contains `null`. Calling `null.toString()` throws a TypeError, crashing the error formatter. Replace `.toString()` with `String(value ?? '')` to safely handle null values in enum suggestions. Co-Authored-By: Claude <noreply@anthropic.com>
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: Cannot read properties of null (reading 'toString')whenallowedValuescontainsnullvalue.toString()withString(value ?? '')to safely handle nullable enumsProblem
When a JSON Schema defines a nullable enum (e.g.,
enum: ['draft', 'posted', null]), AJV includesnullinerror.params.allowedValues. The error formatter calls.toString()on each value, which crashes onnull.This is common in OpenAPI 3.0 specs where fields are both
nullable: trueand have anenumconstraint.Test plan
should not crash when allowedValues contains null🤖 Generated with Claude Code