ci: unify RPM and DEB package signing onto a single key#470
Merged
Conversation
The RPM and DEB publish pipelines used two independent secret sets (RPM_GPG_* vs DEB_GPG_*) for what is, and should be, the same signing key. Because Actions secrets are write-only, whoever wired up a second pipeline could not reuse the first key's material and instead minted a separate key just to populate the other secret — and those extra keys carried expiry dates, so the package repo broke every time one lapsed. Consolidate both pipelines onto the single RPM_GPG_PRIV_KEY / RPM_GPG_PASSPHRASE secret and hardcode the signing key's uid email (public, published in KEYS) instead of keeping it as a secret. This removes the duplicate-secret trap so no future maintainer is nudged into creating a per-pipeline key. After this merges, the repo-level RPM_GPG_* / DEB_GPG_* / GPG_MAIL / GPG_NAME overrides can be deleted so CI falls back to the org-level RPM_GPG_* key. Ref: apache/apisix#13689
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughDEB and RPM publishing workflows now use ChangesShared GPG signing
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
nic-6443
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The RPM and DEB release pipelines used two separate sets of secrets (
RPM_GPG_*vsDEB_GPG_*) for the same signing key. Since GitHub Actions secrets are write-only and not readable, maintainers who later set up the DEB pipeline could not reuse the original RPM key material and had to create a brand-new key to populate the DEB secrets. These newly created keys have expiration dates, and their expiry repeatedly breaks package repository signature verification (see apache/apisix#13689: the expiry of the signing key forrepos.apiseven.comon 2026-07-08 caused all yum/apt installations to fail).Changes
RPM_GPG_PRIV_KEY/RPM_GPG_PASSPHRASEdev@apisix.apache.org, already public in KEYS and not sensitive information) is hardcoded directly into the workflow instead of being stored as a secretRPM_GPG_PUB_KEYandGPG_NAME, which are never read by the scriptsThis change only affects workflow configurations and leaves
utils/*.shuntouched, fundamentally eliminating the root cause that required repeated key regeneration from having two separate sets of secrets maintained independently.Post-Merge Cleanup (Requires Repository/Org Administrator Actions)
After merging, delete the repository-level overriding secrets (
RPM_GPG_*,DEB_GPG_*,GPG_MAIL,GPG_NAME), so the CI pipeline falls back to the org-levelRPM_GPG_*— the original non-expiringdev@apisix.apache.orgsigning key. The online repository metadata will then need to be re-signed with this key for full recovery (this step is independent of this PR).Ref: apache/apisix#13689
Summary by CodeRabbit