Add residual estimator and erase previous one - #10
Open
SebastienMelo wants to merge 1 commit into
Open
Conversation
aperezlebel
reviewed
Apr 24, 2026
|
|
||
| return self | ||
|
|
||
| def GL(self, psr: str = "brier"): |
Owner
There was a problem hiding this comment.
The psr argument is not used and can be removed. Same across methods of GLEstimator.
aperezlebel
reviewed
Apr 24, 2026
| classifier, | ||
| partitioner: str | Partitioner = "decision_tree", | ||
| train_size: float = 0.5, | ||
| estimator: str = "hgb", |
aperezlebel
reviewed
Apr 24, 2026
| def from_name( | ||
| cls, | ||
| name: str, | ||
| verbose: int = 0, |
aperezlebel
reviewed
Apr 24, 2026
| strategy: str = "uniform", | ||
| binwise_fit: bool = True, | ||
| raise_on_fit_error: bool = False, | ||
| verbose: int = 0, |
Owner
There was a problem hiding this comment.
This argument is not used anymore.
aperezlebel
reviewed
Apr 24, 2026
| self.partitioner = partitioner | ||
| self.cv = cv | ||
| residual_estimator: ResidualEstimator = None, | ||
| # t: float = 0.5, |
aperezlebel
reviewed
Apr 24, 2026
| if residual_estimator is not None | ||
| else None | ||
| ) | ||
| # self.t = t |
aperezlebel
requested changes
Apr 24, 2026
aperezlebel
left a comment
aperezlebel
left a comment
Owner
There was a problem hiding this comment.
Thank you for improving the estimator! Could you update the tests with the new estimator? As it stands they are still using the previous one and are thus failing.
aperezlebel
reviewed
Apr 24, 2026
| figsize=(3, 3), | ||
| figsize=(4, 4), | ||
| ) | ||
| _scatter_kw = dict( |
aperezlebel
reviewed
Apr 24, 2026
Comment on lines
64
to
80
| @@ -73,85 +74,111 @@ def grouping_diagram( | |||
| ) | |||
| _legend_kw = dict( | |||
| framealpha=0, | |||
| loc='lower center', | |||
| loc="lower center", | |||
| bbox_to_anchor=(0.5, 1.1) if plot_hist else (0.5, 1), | |||
| ncols=2, | |||
| ) | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds the new estimator for the grouping loss as well as the epistemic risk estimator.