XGC-148: drop commons-io dependency - #32
Conversation
2f13415 to
1d7064b
Compare
|
I see the CI checks fail, and I suggest a fix for it: #33 |
|
@simonsteiner1984 , any thoughts? |
|
Is there a reason of not merging the PR? Frankly, it looks sad to miss myself here: https://github.com/apache/xmlgraphics-commons/graphs/contributors |
|
@simonsteiner1984 , Thanks for landing this. One request on attribution. The change went in verbatim — the squashed commit 22e04a9 is byte-for-byte identical to this PR's diff — but it's authored under your name, with mine only in the message body ("by Vladimir Sitnikov"). GitHub keys the Contributors list and profile activity off the commit's Author field, so the mention doesn't register as a contribution. Since the changes are already in main, I see the following ways to fix the attribution:
Either works. Going forward, merging the PR (or passing |
Fixes https://issues.apache.org/jira/browse/XGC-148
TODO:
IOUtils.closeQuitely— replaced withtry-with-resourcesIOUtils.toString(Reader)— implemented a function in test (it was used in a single test only)IOUtils.copy. Java 9 hasInputStream.transferTo(OutputStream)IOUtils.toByteArray. Java 9 hasInputStream.readAllBytes()commons.io.output.ByteArrayOutputStream. I see that there were no consistent use ofcommons.ByteArrayOutputStream, so I replaced all the usages withjava.io.ByteArrayOutputStreamEndianUtils.readSwappedInteger