Repository navigation
refactor: reduce raw result boilerplate and simplify small patterns - #326
Merged
Merged
Conversation
Add crate-internal tee_check/tee_check_with_origin and teec_check/teec_check_with_origin helpers in the error modules and replace the repeated Ok(())/Err(from_raw_error) arms with them. Let Error::new and Error::from_raw_error delegate to From<ErrorKind>, and simplify the remaining small option and match patterns in optee-teec. Error conversion, origin handling, and return values are unchanged.
Rewrite open, put, get, and delete without nested matches, using map_err(...)? for storage errors and ok_or_else(...) for missing values, and chain the checked_mul/checked_add overflow checks into map. Error messages and returned values are unchanged.
…d helpers Use as_deref().unwrap_or() for the header file name and PathBuf::join in the systest build script, and is_ok_and plus unwrap_or_else for the plugin output checks. No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pure refactor that shrinks repetitive boilerplate across the crates, with no
behavior change and no public API change. Nearly 60 hand-written
matchblockson raw TEE/TEEC result codes are folded into two small crate-internal helpers,
and a handful of nested
match/Optionpatterns are simplified.