ci: remove nightly-build.yml (startup failure from secrets-in-if; unwanted)#155
Merged
Merged
Conversation
nightly-build.yml failed at startup on every scan (zero jobs) because of a secrets-in-if expression: 'if: ${{ secrets.APACHE_NIGHTLIES_USER != '\'''\'' }}'. The secrets context is not available in if: conditions, so GitHub rejects the workflow at parse time — a separate cause from the docker/login-action allow-list issue fixed in apache#153/apache#154.
The nightlies.apache.org upload was only a placeholder and a daily nightly pre-release isn't wanted, so remove the workflow entirely rather than fix the parse error. dev-docs/WORKFLOWS.md and dev-docs/DOCKER_PUBLISHING.md are updated to drop nightly references (dedicated section, comparison-matrix column, scenario, registry list, tagging).
Note: the 'COMPARISON WITH OTHER WORKFLOWS' header comments in build-and-publish.yml, release-publish.yml, and atr-release.yml still list nightly-build; left as-is to avoid conflicts with apache#153/apache#154 which modify the first two.
Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
nightly-build.ymlfails at startup on every workflow scan —job count: 0, surfaced as a red ✗ onmainpushes (e.g. run 27561117336).Root cause is not the
docker/login-actionallow-list issue (this workflow has no third-party actions). It's asecretscontext used in anif::The
secretscontext isn't available inif:conditions, so GitHub rejects the workflow at parse time ("Unrecognized named-value: 'secrets'") → startup failure, before any job runs. (Same red‑✗ symptom as the allow‑list block, different cause.)Why remove rather than fix
The workflow's nightlies.apache.org upload step is an explicit placeholder (it only
echos "Would upload to…"), and a daily nightly GitHub pre-release isn't wanted. Rather than fix the parse error to keep a half-built workflow we don't run, this removes it entirely.Note: just commenting out the
schedule:trigger would not help — the invalid file would still startup-fail and still show red onmain. Deletion is the only way to fully clear it.Changes
.github/workflows/nightly-build.yml(−216).dev-docs/WORKFLOWS.md: drop the nightly Quick-Reference row, the dedicatednightly-build.ymlsection, the Comparison-Matrix column, Scenario 3 (renumbered), and the quick-command line.dev-docs/DOCKER_PUBLISHING.md: drop the Nightly registry entry, the "Nightly Builds" section (renumbered), the tagging line, and the policy-note mention.Out of scope (intentionally)
The "COMPARISON WITH OTHER WORKFLOWS" header comments in
build-and-publish.yml,release-publish.yml, andatr-release.ymlstill listnightly-build. Left as-is here because the first two are modified by #153/#154 — touching them would create conflicts between these companion PRs.Context
Third in a series clearing CI startup failures: #153 (
build-and-publish.yml), #154 (release-publish.yml), and this one. After all three merge, the only remaining red isatr-release.yml— a stale old run on a manual "Blocked/future" workflow whose current file has no detectable startup cause.🤖 Generated with Claude Code