Skip to content

ci: remove nightly-build.yml (startup failure from secrets-in-if; unwanted)#155

Merged
epugh merged 1 commit into
apache:mainfrom
adityamparikh:ci/remove-nightly-build
Jun 19, 2026
Merged

ci: remove nightly-build.yml (startup failure from secrets-in-if; unwanted)#155
epugh merged 1 commit into
apache:mainfrom
adityamparikh:ci/remove-nightly-build

Conversation

@adityamparikh

Copy link
Copy Markdown
Contributor

Problem

nightly-build.yml fails at startup on every workflow scan — job count: 0, surfaced as a red ✗ on main pushes (e.g. run 27561117336).

Root cause is not the docker/login-action allow-list issue (this workflow has no third-party actions). It's a secrets context used in an if::

- name: Upload to Apache Nightlies
  if: ${{ secrets.APACHE_NIGHTLIES_USER != '' }}   # ← secrets not allowed in if:

The secrets context isn't available in if: conditions, so GitHub rejects the workflow at parse time ("Unrecognized named-value: 'secrets'") → startup failure, before any job runs. (Same red‑✗ symptom as the allow‑list block, different cause.)

Why remove rather than fix

The workflow's nightlies.apache.org upload step is an explicit placeholder (it only echos "Would upload to…"), and a daily nightly GitHub pre-release isn't wanted. Rather than fix the parse error to keep a half-built workflow we don't run, this removes it entirely.

Note: just commenting out the schedule: trigger would not help — the invalid file would still startup-fail and still show red on main. Deletion is the only way to fully clear it.

Changes

  • Delete .github/workflows/nightly-build.yml (−216).
  • dev-docs/WORKFLOWS.md: drop the nightly Quick-Reference row, the dedicated nightly-build.yml section, the Comparison-Matrix column, Scenario 3 (renumbered), and the quick-command line.
  • dev-docs/DOCKER_PUBLISHING.md: drop the Nightly registry entry, the "Nightly Builds" section (renumbered), the tagging line, and the policy-note mention.

Out of scope (intentionally)

The "COMPARISON WITH OTHER WORKFLOWS" header comments in build-and-publish.yml, release-publish.yml, and atr-release.yml still list nightly-build. Left as-is here because the first two are modified by #153/#154 — touching them would create conflicts between these companion PRs.

Context

Third in a series clearing CI startup failures: #153 (build-and-publish.yml), #154 (release-publish.yml), and this one. After all three merge, the only remaining red is atr-release.yml — a stale old run on a manual "Blocked/future" workflow whose current file has no detectable startup cause.

🤖 Generated with Claude Code

nightly-build.yml failed at startup on every scan (zero jobs) because of a secrets-in-if expression: 'if: ${{ secrets.APACHE_NIGHTLIES_USER != '\'''\'' }}'. The secrets context is not available in if: conditions, so GitHub rejects the workflow at parse time — a separate cause from the docker/login-action allow-list issue fixed in apache#153/apache#154.

The nightlies.apache.org upload was only a placeholder and a daily nightly pre-release isn't wanted, so remove the workflow entirely rather than fix the parse error. dev-docs/WORKFLOWS.md and dev-docs/DOCKER_PUBLISHING.md are updated to drop nightly references (dedicated section, comparison-matrix column, scenario, registry list, tagging).

Note: the 'COMPARISON WITH OTHER WORKFLOWS' header comments in build-and-publish.yml, release-publish.yml, and atr-release.yml still list nightly-build; left as-is to avoid conflicts with apache#153/apache#154 which modify the first two.

Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@epugh epugh merged commit 91d15e0 into apache:main Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants