Clear 3 security alerts: protobuf e2e fixture CVE-2026-0994 + histogram count narrowing#13921
Merged
Conversation
…arrowing - Dependabot CVE-2026-0994: bump the Airflow e2e mock's pinned protobuf 4.25.8 -> 5.29.6 (no 4.x patch exists) and opentelemetry-proto 1.24.0 -> 1.28.0 (its protobuf<5.0 cap was the blocker). CI-only test fixture, never shipped; grpcio/flask unchanged. - CodeQL java/implicit-cast-in-compound-assignment: widen the cumulative `count` accumulator from int to long in Sum/AvgHistogramPercentileFunction. `count += value` silently narrowed a long bucket-count sum back to int; `total` was already long. Verified: Sum/AvgHistogramPercentileFunctionTest pass (12/12); checkstyle + license clean.
….28.0 stubs opentelemetry-proto 1.28.0's generated gRPC stubs are produced by grpcio-tools >=1.63 and call channel.unary_unary(_registered_method=True), which grpcio 1.62.2 does not accept -> MetricsServiceStub(channel) raised "TypeError: Channel.unary_unary() got an unexpected keyword argument '_registered_method'", so the OTLP replay mock could not build the stub or send metrics. Bump grpcio 1.62.2 -> 1.63.2. Reproduced + verified in python:3.11-slim against the real mock-data: json_format.Parse (protobuf 5.29.6) + MetricsServiceStub construction + stub.Export all work (Export reaches the wire; UNAVAILABLE only because no server is listening). The earlier commit's claim that grpcio was unchanged was wrong.
wankai123
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix three open security alerts (1 Dependabot, 2 code-scanning)
Clears all three open HIGH security alerts on the default branch.
1. Dependabot —
protobufCVE-2026-0994 (JSON recursion-depth DoS)test/e2e-v2/cases/airflow/mock/requirements-replay.txtpinnedprotobuf==4.25.8. There is no patched 4.x release (fix line isprotobuf>=5.29.6), so the OTLP-replay mock's dependency set moves to a coherent protobuf-5 combination:protobuf4.25.8→5.29.6opentelemetry-proto1.24.0→1.28.0— required:1.24.0capsprotobuf<5.0;1.28.0is the earliest release allowingprotobuf>=5.grpcio1.62.2→1.63.2— required:opentelemetry-proto1.28.0's generated gRPC stubs (built withgrpcio-tools>=1.63) callchannel.unary_unary(_registered_method=True), whichgrpcio1.62.2rejects withTypeError, breakingMetricsServiceStub. (flaskunchanged.)This is a CI-only e2e mock (a throwaway Flask/gRPC OTLP emitter), never shipped in the OAP — same class as the earlier test-fixture CVE cleanups (#13913 / #13915).
Verified in
python:3.11-slimagainst the realmock-data:json_format.Parse(protobuf 5.29.6) +MetricsServiceStubconstruction +stub.Exportall work with this set; the priorgrpcio 1.62.2pin raisedTypeError: Channel.unary_unary() got an unexpected keyword argument '_registered_method'.2 & 3. Code-scanning —
java/implicit-cast-in-compound-assignmentIn
SumHistogramPercentileFunctionandAvgHistogramPercentileFunction, the cumulative bucket counter wasint count, butcount += valueadds aLongbucket count — promoting tolong, then silently narrowing back toint.total(the same bucket sum) was alreadylong, so the counter was inconsistent and could truncate aboveInteger.MAX_VALUE.int count→long countin both functions.count >= roof(long ≥ int) still works; no other change needed.Verification:
SumHistogramPercentileFunctionTest+AvgHistogramPercentileFunctionTestpass (12/12); server-core checkstyle and license headers clean; airflow mock dependency set verified to import + parse + build the gRPC stub in thepython:3.11-slimruntime image.CHANGESlog.🤖 Generated with Claude Code