[fix][test] InactiveTopicDeleteTest#testDeleteWhenNoSubscriptionsWithMultiConfig - #19436
Merged
tisonkun merged 2 commits intoJun 13, 2023
Conversation
|
The pr had no activity for 30 days, mark with Stale label. |
tisonkun
approved these changes
Jun 13, 2023
tisonkun
left a comment
tisonkun
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for your contribution @labuladong!
Member
|
Merging... |
labuladong
deleted the
fix/flaky/testDeleteWhenNoSubscriptionsWithMultiConfig
branch
June 13, 2023 09:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19379
Modifications
The two topics will be deleted due to
delete_when_no_subscriptions, but may not be at the same time. So useAwaitilityto ensure they are deleted at the end.Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete