Skip to content

Add job.podAnnotations for the pods created by the chart's Jobs #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhotari merged 3 commits into from
Oct 6, 2026
Merged

Add job.podAnnotations for the pods created by the chart's Jobs #722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6340859
Add job.podAnnotations for the pods created by the chart's Jobs
Laurianti Oct 2, 2026
427aeda
Render job.podAnnotations in the all-values CI render
Laurianti Oct 2, 2026
f80af3e
Merge branch 'master' into job-pod-annotations
lhotari Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .ci/templates-all-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,9 +237,12 @@ auth:
client: "admin"

# -----------------------------------------------------------------------------
# Job TTL -- exercises `if and .Values.job.ttl.enabled` in *-cluster-initialize
# Jobs -- exercises `if and .Values.job.ttl.enabled` in *-cluster-initialize
# and `with .Values.job.podAnnotations` in the Job pod templates
# -----------------------------------------------------------------------------
job:
podAnnotations:
sidecar.istio.io/inject: "false"
ttl:
enabled: true
secondsAfterFinished: 300
Expand Down
4 changes: 4 additions & 0 deletions charts/pulsar/templates/bookkeeper-cluster-initialize.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ spec:
labels:
{{- include "pulsar.template.labels" . | nindent 8 }}
component: {{ .Values.bookkeeper.component }}-init
{{- with .Values.job.podAnnotations }}
annotations:
{{- toYaml . | nindent 8 }}
{{- end }}
spec:
{{- include "pulsar.imagePullSecrets" . | nindent 6 }}
serviceAccountName: "{{ template "pulsar.fullname" . }}-{{ .Values.bookkeeper.component }}"
Expand Down
5 changes: 5 additions & 0 deletions charts/pulsar/templates/broker-statefulset-upgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,11 @@ metadata:
spec:
backoffLimit: 1
template:
{{- with .Values.job.podAnnotations }}
metadata:
annotations:
{{- toYaml . | nindent 8 }}
{{- end }}
spec:
serviceAccountName: "{{ template "pulsar.fullname" . }}-{{ .Values.broker.component }}-sts-cleanup"
restartPolicy: Never
Expand Down
4 changes: 4 additions & 0 deletions charts/pulsar/templates/jwt-secret-init.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ spec:
labels:
{{- include "pulsar.template.labels" . | nindent 8 }}
component: jwt-secret-init
{{- with .Values.job.podAnnotations }}
annotations:
{{- toYaml . | nindent 8 }}
{{- end }}
spec:
{{- include "pulsar.imagePullSecrets" . | nindent 6 }}
serviceAccountName: "{{ template "pulsar.fullname" . }}-jwt-secret-init"
Expand Down
4 changes: 4 additions & 0 deletions charts/pulsar/templates/pulsar-cluster-initialize.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ spec:
labels:
{{- include "pulsar.template.labels" . | nindent 8 }}
component: {{ .Values.pulsar_metadata.component }}
{{- with .Values.job.podAnnotations }}
annotations:
{{- toYaml . | nindent 8 }}
Comment thread
Laurianti marked this conversation as resolved.
{{- end }}
spec:
{{- include "pulsar.imagePullSecrets" . | nindent 6 }}
{{- if .Values.pulsar_metadata.nodeSelector }}
Expand Down
5 changes: 5 additions & 0 deletions charts/pulsar/templates/zookeeper-statefulset-upgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,11 @@ metadata:
spec:
backoffLimit: 1
template:
{{- with .Values.job.podAnnotations }}
metadata:
annotations:
{{- toYaml . | nindent 8 }}
{{- end }}
spec:
serviceAccountName: "{{ template "pulsar.fullname" . }}-{{ .Values.zookeeper.component }}-sts-cleanup"
restartPolicy: Never
Expand Down
3 changes: 3 additions & 0 deletions charts/pulsar/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2277,6 +2277,9 @@ dekaf:
# pulsar-helm-chart/charts/pulsar/templates/bookkeeper-cluster-initialize.yaml
job:
annotations: {}
# Annotations for the pods created by the chart's Jobs, for example
# sidecar.istio.io/inject: "false" so that an Istio sidecar doesn't keep a Job from completing
podAnnotations: {}
Comment thread
Laurianti marked this conversation as resolved.
ttl:
enabled: false
secondsAfterFinished: 3600
Expand Down