Skip to content

fix: don't render PodMonitor and HPA for disabled components #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhotari merged 2 commits into from
Oct 6, 2026
Merged

fix: don't render PodMonitor and HPA for disabled components #717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67701c8
fix: don't render PodMonitor and HPA for disabled components
mouchar Aug 29, 2026
9b193a4
Merge branch 'master' into fix-standalone
lhotari Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/pulsar/templates/autorecovery-podmonitor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# under the License.
#

# deploy autorecovery PodMonitor only when `$.Values.autorecovery.podMonitor.enabled` is true
{{- if and $.Values.autorecovery.podMonitor.enabled (not $.Values.standalone.enabled) }}
# deploy autorecovery PodMonitor only when the autorecovery component and `$.Values.autorecovery.podMonitor.enabled` are both enabled
{{- if and $.Values.components.autorecovery $.Values.autorecovery.podMonitor.enabled (not $.Values.standalone.enabled) }}
{{- include "pulsar.podMonitor" (list . "autorecovery" (printf "component: %s" .Values.autorecovery.component)) }}
{{- end }}
4 changes: 2 additions & 2 deletions charts/pulsar/templates/bookkeeper-podmonitor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# under the License.
#

# deploy bookkeeper PodMonitor only when `$.Values.bookkeeper.podMonitor.enabled` is true
{{- if and $.Values.bookkeeper.podMonitor.enabled (not $.Values.standalone.enabled) }}
# deploy bookkeeper PodMonitor only when the bookkeeper component and `$.Values.bookkeeper.podMonitor.enabled` are both enabled
{{- if and $.Values.components.bookkeeper $.Values.bookkeeper.podMonitor.enabled (not $.Values.standalone.enabled) }}
{{- include "pulsar.podMonitor" (list . "bookkeeper" (printf "component: %s" .Values.bookkeeper.component)) }}
{{- end }}
2 changes: 1 addition & 1 deletion charts/pulsar/templates/broker-hpa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# under the License.
#

{{- if and .Values.broker.autoscaling.enabled (not .Values.standalone.enabled) }}
{{- if and .Values.components.broker .Values.broker.autoscaling.enabled (not .Values.standalone.enabled) }}
{{- if (semverCompare "<1.23-0" .Capabilities.KubeVersion.Version) }}
apiVersion: autoscaling/v2beta2
{{- else }}
Expand Down
4 changes: 2 additions & 2 deletions charts/pulsar/templates/broker-podmonitor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# under the License.
#

# deploy broker PodMonitor only when `$.Values.broker.podMonitor.enabled` is true
{{- if and $.Values.broker.podMonitor.enabled (not $.Values.standalone.enabled) }}
# deploy broker PodMonitor only when the broker component and `$.Values.broker.podMonitor.enabled` are both enabled
{{- if and $.Values.components.broker $.Values.broker.podMonitor.enabled (not $.Values.standalone.enabled) }}
{{- include "pulsar.podMonitor" (list . "broker" (printf "component: %s" .Values.broker.component)) }}
{{- end }}
2 changes: 1 addition & 1 deletion charts/pulsar/templates/proxy-hpa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# under the License.
#

{{- if .Values.proxy.autoscaling.enabled }}
{{- if and .Values.components.proxy .Values.proxy.autoscaling.enabled }}
{{- if (semverCompare "<1.23-0" .Capabilities.KubeVersion.Version) }}
apiVersion: autoscaling/v2beta2
{{- else }}
Expand Down
4 changes: 2 additions & 2 deletions charts/pulsar/templates/proxy-podmonitor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# under the License.
#

# deploy proxy PodMonitor only when `$.Values.proxy.podMonitor.enabled` is true
{{- if $.Values.proxy.podMonitor.enabled }}
# deploy proxy PodMonitor only when the proxy component and `$.Values.proxy.podMonitor.enabled` are both enabled
{{- if and $.Values.components.proxy $.Values.proxy.podMonitor.enabled }}
{{- include "pulsar.podMonitor" (list . "proxy" (printf "component: %s" .Values.proxy.component) "sts-http") }}
{{- end }}