Remove listNamespaces(Namespace) convenience overload from IcebergCatalogHandler - #5227
Open
ParasdotDev wants to merge 2 commits into
Open
Remove listNamespaces(Namespace) convenience overload from IcebergCatalogHandler#5227ParasdotDev wants to merge 2 commits into
ParasdotDev wants to merge 2 commits into
Conversation
…alogHandler (part of apache#4709)
adutra
previously approved these changes
Aug 3, 2026
github-project-automation
Bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
flyrain
reviewed
Aug 3, 2026
| PolarisAuthorizableOperation op = PolarisAuthorizableOperation.LIST_NAMESPACES; | ||
| authorizeBasicNamespaceOperationOrThrow(op, parent); | ||
|
|
||
| return catalogHandlerUtils().listNamespaces(namespaceCatalog, parent); |
Contributor
There was a problem hiding this comment.
Same comments for catalogHandlerUtils().listNamespaces(), should we remove it as well?
Contributor
Author
There was a problem hiding this comment.
Removed it as well in the latest commit.
…es, Namespace) helper
adutra
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
listNamespaces(Namespace)overload was only called from test code and diverged from theproduction
listNamespaces(Namespace, pageToken, pageSize)path: it skipped theisFederatedbranch and pagination. This removes it and updates the 11 authz-test call sites to the
production overload.
Part of #4709.
Checklist
IcebergCatalogHandler.createTableDirectWithWriteDelegation()#4709:polaris-runtime-service:checkpassesCHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)