Skip to content

chore: Make AddFutureAwaitResult an AnyVal - #647

Merged
pjfanning merged 3 commits into
apache:mainfrom
He-Pin:anyVal
May 9, 2025
Merged

chore: Make AddFutureAwaitResult an AnyVal#647
pjfanning merged 3 commits into
apache:mainfrom
He-Pin:anyVal

Conversation

@He-Pin

@He-Pin He-Pin commented Jan 4, 2025

Copy link
Copy Markdown
Member

Motivation:
less allocation.

Result:
less allocation

Note: The code it's self seems only been used in tests.

@pjfanning

Copy link
Copy Markdown
Member

mima issue for scala 3 build

[error]  * static method AddFutureAwaitResult(scala.concurrent.Future)org.apache.pekko.http.impl.util.package#AddFutureAwaitResult in class org.apache.pekko.http.impl.util.package has a different result type in current version, where it is scala.concurrent.Future rather than org.apache.pekko.http.impl.util.package#AddFutureAwaitResult
[error]    filter with: ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.pekko.http.impl.util.package.AddFutureAwaitResult")

@pjfanning pjfanning added this to the 1.2.0 milestone Jan 9, 2025
@raboof

raboof commented Jan 9, 2025

Copy link
Copy Markdown
Member

mima issue for scala 3 build

[error]  * static method AddFutureAwaitResult(scala.concurrent.Future)org.apache.pekko.http.impl.util.package#AddFutureAwaitResult in class org.apache.pekko.http.impl.util.package has a different result type in current version, where it is scala.concurrent.Future rather than org.apache.pekko.http.impl.util.package#AddFutureAwaitResult
[error]    filter with: ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.pekko.http.impl.util.package.AddFutureAwaitResult")

that is weird, but as this class is private[http] can be safely ignored AFAICS

@pjfanning

Copy link
Copy Markdown
Member

@He-Pin are you interested in completing this? I'm planning to push for a release soon.

@He-Pin

He-Pin commented May 7, 2025

Copy link
Copy Markdown
Member Author

@pjfanning I'm just back from the Labor holiday, will take a look soon.

@He-Pin He-Pin closed this May 7, 2025
@He-Pin He-Pin reopened this May 7, 2025
@He-Pin
He-Pin requested review from pjfanning and raboof May 7, 2025 07:16
@He-Pin

He-Pin commented May 9, 2025

Copy link
Copy Markdown
Member Author

Thanks for take care of this, I'm at airport

@pjfanning pjfanning mentioned this pull request May 9, 2025

@pjfanning pjfanning left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning
pjfanning merged commit 4564c1b into apache:main May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants