refactor: remove deprecated scalaPartialFunction (since 1.2.0)#778
Draft
He-Pin wants to merge 1 commit into
Draft
refactor: remove deprecated scalaPartialFunction (since 1.2.0)#778He-Pin wants to merge 1 commit into
He-Pin wants to merge 1 commit into
Conversation
Motivation: scalaPartialFunction was deprecated since pekko-grpc 1.2.0 as it is no longer needed since support for Scala 2.11 was dropped. Modification: Remove the deprecated scalaPartialFunction method and inline its logic into scalaAnonymousPartialFunction. Remove unused @nowarn import. Add MiMa filter for the removed method. Result: Cleaner API surface with one less deprecated method. Tests: Not run - trivial inline refactor References: None - deprecated API cleanup
He-Pin
force-pushed
the
remove/deprecated-scalaPartialFunction
branch
from
43138bd to
33c2cea
Compare
Member
|
This was only recently deprecated and I prefer to keep deprecated code around for a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
scalaPartialFunctionwas deprecated since pekko-grpc 1.2.0 as it is no longer needed since support for Scala 2.11 was dropped.Modification
Remove the deprecated
scalaPartialFunctionmethod and inline its logic intoscalaAnonymousPartialFunction. Remove unused@nowarnimport.Result
Cleaner API surface with one less deprecated method.
Tests
Not run - trivial inline refactor
References
None - deprecated API cleanup