Fixing the vercel_artifacts backend#7793
Open
krishnamanchikalapudi wants to merge 3 commits into
Open
Conversation
dosubot
Bot
added
size:XS
3 tasks
…s CAS constraints Explain why create_dir, delete, and list are unsupported: Vercel Remote Cache is content-addressable storage and does not expose folder operations or cache deletion via its API. Add a Limitations section to docs.md and inline comments to the relevant backend methods. Addresses reviewer feedback on apache#7793.
dosubot
Bot
added
size:S
Author
|
Thanks for the review @erickguan! I've pushed two follow-up commits addressing the feedback:
Summary of what this PR fixes vs. what's inherently unsupported:
Let me know if anything else needs adjusting! |
Member
|
Nice! Can you run a behavior test against Vercel? I know there is a test in a GitHub workflow. You might need to research a little to find out how to use it. The other alternative is to run OPENDAL_TEST=vercel_artifacts cargo test behavior --features tests,services-vercel-artifacts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2198
Rationale for this change
Explaining vercel_artifacts CAS limitations and why stat was needed while skipping delete/create_dir
What changes are included in this PR?
Implementing stat, handling slash directory fast-paths, keeping unsupported capabilities disabled
Are there any user-facing changes?
No user-facing breaking changes
AI Usage Statement
AI coding assistant usage statement