xtensa/esp32s3: drop redundant CONFIG_UORB_STACKSIZE from defconfig - #20052
Merged
acassis merged 1 commit intoSep 4, 2026
Merged
Conversation
FelipeMdeO
changed the title
github-actions
Bot
added
Size: XS
|
xiaoxiang781216
approved these changes
Sep 3, 2026
Contributor
|
fix style error: |
nuttx-apps PR apache#3763 adds "default 4096 if LIBC_PRINT_EXTENSION" to CONFIG_UORB_STACKSIZE. Both lckfb-szpi-esp32s3/qmi8658 and esp32s3-ws-lcd128/imu-qmi8658 already set CONFIG_UORB_STACKSIZE=4096 explicitly, which now matches the new default and makes the line redundant, so savedefconfig drops it -- causing the CI defconfig-sync check (testbuild.sh -R) to flag these files as stale and fail the xtensa-03 job. Signed-off-by: Felipe Moura <moura.fmo@gmail.com> Assisted-by: Claude:claude-sonnet-5
FelipeMdeO
force-pushed
the
fix/uorb-stacksize-defconfig-sync
branch
from
September 4, 2026 13:08
734c06c to
767f1e7
Compare
xiaoxiang781216
approved these changes
Sep 4, 2026
Contributor
Author
acassis
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apache/nuttx-apps#3763 adds
default 4096 if LIBC_PRINT_EXTENSIONtoCONFIG_UORB_STACKSIZE. Two boards already setCONFIG_UORB_STACKSIZE=4096explicitly in their defconfig, which now matches the new default and makes the line redundant.savedefconfigdrops it, so the CI defconfig-sync check fails on these two boards once nuttx-apps#3763 is applied.This PR removes the now-redundant line from:
boards/xtensa/esp32s3/lckfb-szpi-esp32s3/configs/qmi8658/defconfigboards/xtensa/esp32s3/esp32s3-ws-lcd128/configs/imu-qmi8658/defconfigNeeded for apache/nuttx-apps#3763's CI (job
Linux (xtensa-03)) to pass — please merge together / in coordination with that PR.Test
Confirmed the diff matches exactly what CI's
testbuild.sh -Rproduced when normalizing these two configsgrep -r "CONFIG_UORB_STACKSIZE=4096" boards/returns no other affected boards