Skip to content

arch/arm/nrf53: fix inverted GPIOTE per-instance channel index #20002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaoxiang781216 merged 2 commits into from
Aug 31, 2026
Merged

arch/arm/nrf53: fix inverted GPIOTE per-instance channel index #20002

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
815d136
arch/arm/nrf53: fix inverted GPIOTE per-instance channel index
AlmAck Aug 29, 2026
16f8775
arch/arm/nrf53: fix nxstyle errors in nrf53_gpiote.c
AlmAck Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions arch/arm/src/nrf53/nrf53_gpiote.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ static int nrf53_gpiote_isr(int irq, void *context, void *arg)

xcpt_t callback = g_gpiote_ch_callbacks[off].callback;
void *cbarg = g_gpiote_ch_callbacks[off].arg;

ret = callback(irq, context, cbarg);

/* Clear event */
Expand Down Expand Up @@ -210,10 +211,11 @@ static int nrf53_gpiote_isr(int irq, void *context, void *arg)
{
case 0:
addr = NRF53_GPIO_P0_BASE + NRF53_GPIO_LATCH_OFFSET;
break;
break;

case 1:
addr = NRF53_GPIO_P1_BASE + NRF53_GPIO_LATCH_OFFSET;
break;
break;
}

/* Retrieve LATCH register */
Expand Down Expand Up @@ -256,7 +258,7 @@ static int nrf53_gpiote_isr(int irq, void *context, void *arg)
ret = callback(irq, context, cbarg);
}
#endif
}
}
}

return ret;
Expand Down Expand Up @@ -405,7 +407,7 @@ void nrf53_gpiote_set_ch_event(uint32_t pinset, int channel,
inst = 0;
#endif

rchan = (inst == 1) ? channel : (channel - GPIOTE_PER_CHANNEL);
rchan = (inst == 1) ? (channel - GPIOTE_PER_CHANNEL) : channel;

/* NOTE: GPIOTE module has priority over GPIO module
* so GPIO configuration will be ignored
Expand Down Expand Up @@ -567,7 +569,7 @@ void nrf53_gpiote_set_task(uint32_t pinset, int channel,
inst = 0;
#endif

rchan = (inst == 1) ? channel : (channel - GPIOTE_PER_CHANNEL);
rchan = (inst == 1) ? (channel - GPIOTE_PER_CHANNEL) : channel;

/* Select GPIOTE pin */

Expand Down
Loading