arch/avr/src/avrdx: Add TWI support, fix missing pins code, doc update. - #17404
Merged
Conversation
This was referenced Nov 29, 2025
xiaoxiang781216
previously approved these changes
Nov 29, 2025
The Kconfig configuration was offering alternate routing options for USART peripherals but there was no code which would act on those settings. This patch fixes it. Additionally, since the code is being worked on, this patch also renames USART-related configuration options from AVR_HAS_ to AVR_HAVE_ . This is based on GitHub and mailing list discussion where it was pointed out that other architectures use "HAVE". Patch was tested by choosing few combinations of the configuration and verifying which registers are being set in disassembly. Base configuration was also tested by an application that uses two ports. Signed-off-by: Kerogit <kr.git@kerogit.eu>
cederom
force-pushed
the
avrdx_twi_rfc1-2
branch
from
November 29, 2025 17:02
3f20013 to
f992e92
Compare
Contributor
Author
|
Response from kerogit:
|
This patch adds support for Two-Wire interface in AVR Dx chips. Only master mode is supported in this version. The driver was tested using TC74Ax thermal sensor and simple application that read the temperature from it. (Driver for the sensor is not in-tree.) Signed-off-by: Kerogit <kr.git@kerogit.eu>
cederom
force-pushed
the
avrdx_twi_rfc1-2
branch
from
November 29, 2025 17:10
f992e92 to
1a11d6f
Compare
Contributor
Author
|
Typos fixed, lets see now :-) |
xiaoxiang781216
approved these changes
Nov 30, 2025
jerpelea
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a PR transfer from kerogit delivered over mailing list.
This patch adds support for Two-Wire interface in AVR Dx chips. Only master mode is supported in this version.
The Kconfig configuration was offering alternate routing options for USART peripherals but there was no code which would act on those settings. This patch fixes it.
Additionally, since the code is being worked on, this patch also renames USART-related configuration options from
AVR_HAS_toAVR_HAVE_. This is based on GitHub and mailing list discussion where it was pointed out that other architectures use "HAVE".Documentation updates and fixes.
Depends-on: #17403.
Impact
Testing