Fix Spotless config in its/core-it-suite to enforce formatting rules#12324
Open
gnodet wants to merge 4 commits into
Open
Fix Spotless config in its/core-it-suite to enforce formatting rules#12324gnodet wants to merge 4 commits into
gnodet wants to merge 4 commits into
Conversation
The pluginManagement override for spotless-maven-plugin in its/core-it-suite/pom.xml only had <includes> and <excludes>, which wiped out the formatting steps (palantirJavaFormat, removeUnusedImports, importOrder, licenseHeader, sortPom) since the its/ parent chain (apache:38) does not inherit from maven-parent where these steps are defined. Add the formatting steps explicitly and the maven-shared-resources dependency (for importOrder and licenseHeader config files), then apply formatting to all files in the module. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…sion Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
force-pushed
the
fix/spotless-its-formatting-steps
branch
from
3f1ad76 to
50b9803
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
its/core-it-suite/pom.xmlpluginManagement override forspotless-maven-pluginonly specified<includes>and<excludes>, which inadvertently wiped out the formatting steps (palantirJavaFormat,removeUnusedImports,importOrder,licenseHeaderfor Java;sortPomfor POM).its/parent chain inherits fromapache:38(notmaven-parent:48where these steps are defined), so there was no parent config to inherit —combine.children="append"alone could not fix this.maven-shared-resourcesdependency (needed forimportOrderandlicenseHeaderconfig files), and applied formatting to all files in the module.Test plan
mvn -B com.diffplug.spotless:spotless-maven-plugin:check -f its/core-it-suitepassesClaude Code on behalf of Guillaume Nodet