RequireFilesExist should accept a file reached through .. (#977) - #1011
Open
AzazelSensei wants to merge 1 commit into
Open
RequireFilesExist should accept a file reached through .. (#977)#1011AzazelSensei wants to merge 1 commit into
AzazelSensei wants to merge 1 commit into
Conversation
The rule compared the configured path's URI to getCanonicalFile(). A path that still contains .. never matches, so a file that exists is reported missing. I collapse those segments first and compare the file names, which is what the Windows case check needs anyway. Fixes apache#977
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
RequireFilesExist compared the configured path's URI to getCanonicalFile(). A path with
..never matches, so a file that exists is reported missing. I hit this on macOS with${project.basedir}/../../../README.adoc.I collapse
..first and then compare the file names. That keeps the Windows case check and also survives/varvs/private/varon macOS temp dirs.TestRequireFilesExist.testFileExistsThroughDotDotfails on the old URI compare.Fixes #977