fix(skills): clear mechanical SOFT validator warnings#642
Open
justinmclean wants to merge 1 commit into
Open
Conversation
Three non-judgement SOFT warnings eliminated: * reviewer-routing: remove <tracker> from placeholder comment — the skill reads from <upstream> only; the stale placeholder entry was triggering a false-positive privacy-llm-gate advisory. * security-issue-import: add --limit 5 to the rejections-ledger gh issue list call — unbounded calls silently cap at 30 results; the ledger issue is a singleton so 5 is a safe, explicit bound. * release-prepare: replace --body "<body>" with --body-file flow for the gh issue create in Step 1 — eliminates security-pattern-9 advisory about inline shell arguments. Validator passes: 264 tests green; remaining SOFT warnings are all asf-coupling [low] and one action-inventory, both deferred to item 4. Generated-by: Claude (Opus 4.7)
rzo1
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three non-judgement SOFT warnings eliminated:
reviewer-routing: remove from placeholder comment — the skill reads from only; the stale placeholder entry was triggering a false-positive privacy-llm-gate advisory.
security-issue-import: add --limit 5 to the rejections-ledger gh issue list call — unbounded calls silently cap at 30 results; the ledger issue is a singleton so 5 is a safe, explicit bound.
release-prepare: replace --body "" with --body-file flow for the gh issue create in Step 1 — eliminates security-pattern-9 advisory about inline shell arguments.
Validator passes: 264 tests green; remaining SOFT warnings are all asf-coupling [low] and one action-inventory, both deferred to item 4.
Generated-by: Claude (Opus 4.7)
Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek run --all-filespassesuv run pytest/ruff check/mypypasses(
PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/)(a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)