refactor(config): rename role_flags.pmc_member → governance_member#636
Merged
Conversation
added 2 commits
June 29, 2026 07:46
Make the user-config governance-authorisation flag organization-agnostic. The flag answers "is this user authorised under the project's `governance.cve_allocation_gate`?" — for the ASF organization that gate is `pmc-member`, but the flag itself should not be ASF-named. - `role_flags.pmc_member` → `role_flags.governance_member` in the user.md template + the structured-question batch (skills/setup/adopt.md). - security-cve-allocate reads `role_flags.governance_member`; the parenthetical now explains it as a generic boolean resolved against the gate, with `pmc-member` as the ASF example rather than the hardcoded default. - Eval fixtures (security-cve-allocate step-3) updated to provide `governance_member`. Completes the deliberate keep noted in the governance-vocabulary sweep. Generated-by: Claude Code (Opus 4.8)
…e eval Extends the governance_member rename to the spots that still named PMC: - AGENTS.md + docs/setup/unadopt.md: "PMC status" → "governance membership" (and "PMC status, ASF committer role" → "Governing-body membership, committer role" in the external-content authority test). - security-cve-allocate step-3 eval: rename the fixtures case-1-pmc-member → case-1-governance-member and case-2-non-pmc → case-2-non-member (cases are auto-discovered by iterdir, no references to update); "## User PMC status" → "## User governance membership"; output-spec + expected.json key `pmc_path` → `governance_member_path`; README "PMC vs non-PMC" → "member vs non-member". Vulnogram URL assertion left as-is — that tests the ASF CVE-tool backend, a separate axis. Left: committer-onboarding's `committer_governance.model: asf-pmc` row, which already enumerates non-ASF alternatives (github-codeowners, maintainer-roster) and belongs to the ASF-scoped contributor-growth family. Validator EXIT 0; output-spec ↔ expected.json keys consistent. Generated-by: Claude Code (Opus 4.8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes the user-config governance-authorisation flag organization-agnostic
(the deliberate keep noted in #633). The flag answers "is this user
authorised under the project's
governance.cve_allocation_gate?" — forthe ASF organization that gate is
pmc-member, but the flag itselfshouldn't be ASF-named.
role_flags.pmc_member→role_flags.governance_memberin the user.mdtemplate + the structured-question batch (
skills/setup/adopt.md).security-cve-allocatereadsrole_flags.governance_member; theexplanation now frames it as a generic boolean resolved against the
gate, with
pmc-memberas the ASF example rather than the hardcodeddefault name.
governance_member.Verification
No
pmc_memberremains anywhere;skill-and-tool-validateEXIT 0;markdownlint, lychee, placeholder check green. Skill and both eval
fixtures consistently use
governance_member.🤖 Generated with Claude Code