Add native JsonTemplateLayout resolvers for W3C tracing fields#4175
Open
ramanathan1504 wants to merge 2 commits into
Open
Add native JsonTemplateLayout resolvers for W3C tracing fields#4175ramanathan1504 wants to merge 2 commits into
ramanathan1504 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #4171
As discussed with @rgoers, this PR adds the
TraceIdResolver,SpanIdResolver, andTraceFlagsResolverto log4j-layout-template-json.Currently, users outputting structured JSON to Elasticsearch would have to fall back to the pattern resolver
({"$resolver": "pattern", "pattern": "%traceId"}), which introduces intermediate StringBuilder allocations.By providing these native
JTLevent resolvers, structured logging can utilize the native trace fields with absolute zero-allocation performance on the hot path.