Skip to content

Fix flaky WALNode outdated file deletion test #17921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Caideyipi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix flaky WALNode outdated file deletion test #17921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions ...node/src/test/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNodeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,9 +332,7 @@ public void testConcurrentCheckpoint() throws Exception {

@Test
public void testDeleteOutdatedFiles() throws Exception {
List<WALFlushListener> walFlushListeners = new ArrayList<>();
// write until log is rolled
long time = 0;
// write data to make the first WAL file non-empty
IMemTable memTable = new PrimitiveMemTable(databasePath, dataRegionId);
long memTableId = memTable.getMemTableId();
String tsFilePath =
Expand All @@ -352,18 +350,16 @@ public void testDeleteOutdatedFiles() throws Exception {
.setDataRegion(
new DataRegionId(1), new DataRegionTest.DummyDataRegion(logDirectory, databasePath));
walNode.onMemTableCreated(memTable, tsFilePath);
while (time < 20000) {
++time;
for (long time = 1; time <= 100; ++time) {
InsertTabletNode insertTabletNode =
getInsertTabletNode(devicePath + memTableId, new long[] {time});
WALFlushListener walFlushListener =
walNode.log(
memTableId,
insertTabletNode,
Collections.singletonList(new int[] {0, insertTabletNode.getRowCount()}));
walFlushListeners.add(walFlushListener);
walNode.log(
memTableId,
insertTabletNode,
Collections.singletonList(new int[] {0, insertTabletNode.getRowCount()}));
}
walNode.onMemTableFlushed(memTable);
walNode.rollWALFile();
walNode.onMemTableCreated(new PrimitiveMemTable(databasePath, dataRegionId), tsFilePath);
Awaitility.await().until(() -> walNode.isAllWALEntriesConsumed());
// check existence of _0-0-0.wal file and _1-0-1.wal file
Expand Down
Loading