Fix pipe schema snapshot database creation#17910
Open
Caideyipi wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #17910 +/- ##
============================================
+ Coverage 40.83% 41.06% +0.22%
Complexity 318 318
============================================
Files 5245 5248 +3
Lines 363206 364215 +1009
Branches 46780 47046 +266
============================================
+ Hits 148328 149572 +1244
+ Misses 214878 214643 -235 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This patch creates the exact tree-model database on the receiver before replaying a schema region snapshot. Without this, replayed schema statements may trigger auto database creation with the receiver-side default database level, creating an ancestor database such as
oot.test. Later synchronization of the real source databases, for example
oot.test.g_0 or
oot.test.sg_0, then conflicts with that ancestor database and realtime tablet events fail because the exact database does not exist.
The change also treats an already-existing exact database as idempotent success and maps database conflicts during this pre-create step to pipe receiver user conflicts.
Tests