Fix procedure lock wait scheduling#17907
Open
Caideyipi wants to merge 1 commit into
Open
Conversation
Caideyipi
force-pushed
the
fix-procedure-lock-wait
branch
from
984eef3 to
5b637e2
Compare
Caideyipi
force-pushed
the
fix-procedure-lock-wait
branch
from
5b637e2 to
c25849a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes flaky procedure lock wait scheduling by moving LOCK_EVENT_WAIT enqueueing into a procedure hook instead of hard-casting ProcedureExecutor to ConfigNodeProcedureEnv. It also updates the test scheduler to enqueue waiting procedures only after the current execution attempt completes, preserves the exact procedure that should wait/yield during rollback stack handling, and makes root-stack/worker execution cleanup exception-safe. Tests: mvn -pl iotdb-core/confignode -am -Dtest=TestLockRegime#testAcquireLock -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false test; mvn -pl iotdb-core/confignode -am -Dtest=TestLockRegime#testAcquireLock,STMProcedureTest#testRolledBackProcedure -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false test