[MINOR] Preserve original cause in ReadException on close failure#827
Merged
the-other-tim-brown merged 1 commit intoJun 6, 2026
Conversation
HudiDataFileExtractor.close() wrapped any failure from closing the table metadata or file system view in a new ReadException without passing the caught exception as the cause. This discarded the original stack trace and root cause (e.g. I/O or permission errors), making such failures hard to diagnose. Pass the caught exception to the ReadException(message, Throwable) constructor so the original cause is preserved in the exception chain.
the-other-tim-brown
approved these changes
Jun 6, 2026
Contributor
|
Thanks for the fix @alealandreev! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
HudiDataFileExtractor.close()wrapped any failure from closing the tablemetadata or file system view in a new
ReadExceptionwithout passing thecaught exception as the cause. This discarded the original stack trace and
root cause (e.g. I/O or permission errors), making such failures hard to
diagnose.
Brief change log
ReadException(message, Throwable)constructor in
HudiDataFileExtractor.close()so the original cause ispreserved in the exception chain.
Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.