Skip to content

fix: Update Python binding test fixtures to close catalogs #2721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dannycjones wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −4
Open

fix: Update Python binding test fixtures to close catalogs #2721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions bindings/python/tests/test_datafusion_table_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,16 @@ def warehouse(tmp_path_factory: pytest.TempPathFactory) -> Path:


@pytest.fixture(scope="session")
def catalog(warehouse: Path) -> Catalog:
def catalog(warehouse: Path):
catalog = load_catalog(
"default",
**{
"uri": f"sqlite:///{warehouse}/pyiceberg_catalog.db",
"warehouse": f"file://{warehouse}",
},
)
return catalog
yield catalog
catalog.close()


@pytest.fixture(scope="session")
Expand Down
7 changes: 5 additions & 2 deletions bindings/python/tests/test_huggingface_and_cdc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,15 @@
@pytest.fixture(scope="module")
def local_catalog(tmp_path_factory: pytest.TempPathFactory):
warehouse = tmp_path_factory.mktemp("cdc_warehouse")
return load_catalog(
catalog = load_catalog(
"default",
**{
"uri": f"sqlite:///{warehouse}/pyiceberg_catalog.db",
"warehouse": f"file://{warehouse}",
},
)
yield catalog
catalog.close()


@pytest.fixture(scope="module")
Expand Down Expand Up @@ -168,7 +170,8 @@ def hf_cdc_table(sample_table):
# HfFileSystem.dircache may reflect the pre-write state; invalidate it so
# subsequent reads (info/open) see the files just uploaded via xet.
tbl.io.get_fs("hf").invalidate_cache()
return tbl, token
yield tbl, token
catalog.close()


@requires_hf
Expand Down
Loading