[security] Restrict plugin upload endpoint to admin role (#4149) - #4257
Open
Bhavya-Sonigra wants to merge 12 commits into
Open
[security] Restrict plugin upload endpoint to admin role (#4149)#4257Bhavya-Sonigra wants to merge 12 commits into
Bhavya-Sonigra wants to merge 12 commits into
Conversation
…ad of hardcoded default (apache#4218)
Signed-off-by: Bhavya Sonigra <sonigrabhavya28@gmail.com>
Author
|
Hi! Just following up on this PR. I've resolved the merge conflicts and updated the branch with the latest master. Whenever someone has time, I'd really appreciate a review. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4149
What's changed?
The
/api/pluginendpoint had no role-based access control insureness.yml, unlike every other API path in the file. Since plugin upload loads custom JAR code into the JVM via ServiceLoader, this meant any authenticated (or in some cases unauthenticated) user could manage plugins with the same access as an admin.This PR adds explicit admin-only role mappings for
/api/plugin/**, following the exact pattern used elsewhere in the file:Tested locally:
/api/pluginwith no auth token →401 Unauthorized/api/pluginwith an admin token →200 OKwith expected dataChecklist