HBASE-30253 Do not add/remove peer between tests in TestBulkLoadRepli… - #8404
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the TestBulkLoadReplication integration test to keep replication peers stable across test methods, avoiding re-adding/removing peers between tests which can cause previously completed bulk-load replication jobs to be resubmitted (HBASE-30253).
Changes:
- Add the
UTIL1 -> UTIL2replication peer during@BeforeAllto fully establish the1 <-> 2 <-> 3topology up front. - Override
setUpBase/tearDownBaseto prevent per-test peer add/remove from the base class while still resettingBULK_LOADS_COUNTper test.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ReplicationPeerConfig peer3Config = getPeerConfigForCluster(UTIL3); | ||
| // Setup following topology: "1 <-> 2 <-> 3", 1 -> 2 will be added by setUpBase method in parent | ||
| // class | ||
| // Setup following topology: "1 <-> 2 <-> 3" |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
liuxiaocs7
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cation