Repository navigation
YARN-11992. Preserve reservation result and node during multi-node allocation - #8752
Open
luoyuan3471 wants to merge 1 commit into
Open
luoyuan3471 wants to merge 1 commit into
luoyuan3471 wants to merge 1 commit into
Conversation
luoyuan3471
force-pushed
the
YARN-11992
branch
from
September 29, 2026 09:57
dbaa66a to
4933292
Compare
Contributor
Author
|
Hi @slfan1989, could you please take a look when you have time? This fixes a multi-node reservation issue in |
luoyuan3471
force-pushed
the
YARN-11992
branch
from
October 12, 2026 02:29
4933292 to
442dd9e
Compare
luoyuan3471
force-pushed
the
YARN-11992
branch
2 times, most recently
from
October 13, 2026 02:29
130cc84 to
462cf6a
Compare
luoyuan3471
force-pushed
the
YARN-11992
branch
from
October 13, 2026 09:12
462cf6a to
8765ce2
Compare
|
🎊 +1 overall
This message was automatically generated. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Multi-node allocation can reserve a container on an earlier candidate, then overwrite the allocation result when a later node is skipped during the node precheck. When candidate traversal ends, the earlier reservation is discarded or may be completed against the wrong node.
This change tracks the latest reservation together with the node that produced it, completes that reservation after later node-level skips, and returns successful allocations directly so they cannot fall back to a stale reservation.
JIRA: https://issues.apache.org/jira/browse/YARN-11992
How was this patch tested?
TestRegularContainerAllocatorfor preserving an earlier reservation after a later candidate is skipped, completing the reservation on its original node, and avoiding fallback to a stale reservation whendoAllocationdoes not allocate.TestRegularContainerAllocator: 3 tests passed.TestCapacitySchedulerMultiNodes: 8 tests passed;