[MOVED] fix(kms): Package providers in the server distribution#12144
Closed
nevzheng wants to merge 12 commits into
Closed
[MOVED] fix(kms): Package providers in the server distribution#12144nevzheng wants to merge 12 commits into
nevzheng wants to merge 12 commits into
Conversation
2 tasks
Code Coverage Report
Files |
Collaborator
Author
|
Moved to datastrato/gravitino-enterprise#909 under enterprise epic #899. Apache OSS scope remains #12132 and #12133 under #12131. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
kms-providersand load that directory from the server launcher.Why are the changes needed?
The provider modules register
KmsClientFactoryimplementations, but the server distribution previously excluded their artifacts. A packaged server with a configured KMS source therefore could not discover its factory.This work is now tracked in datastrato/gravitino-enterprise#909. The Apache OSS foundation remains #12132 and #12133.
Does this PR introduce any user-facing change?
Yes. Named KMS sources now work in the packaged Gravitino server. No configuration keys change. The four provider bundles add approximately 79 MiB to the unpacked distribution.
How was this patch tested?
./gradlew spotlessApply compileDistribution -PskipWeb=true -x test./gradlew :api:test :core:test :bundles:aws:test :bundles:gcp:test :bundles:azure:test :bundles:transit:test -PskipITs -PskipDockerTests=true -PskipWeb=truekms-providersdirectory.git diff --checkbash -n bin/gravitino.sh.templateMigration