Skip to content

fix(line): respect disabled emphasis in hover. close #21634#21664

Open
rahul37wallst-sudo wants to merge 1 commit into
apache:masterfrom
rahul37wallst-sudo:investigate-21634-dirty-rect
Open

fix(line): respect disabled emphasis in hover. close #21634#21664
rahul37wallst-sudo wants to merge 1 commit into
apache:masterfrom
rahul37wallst-sudo:investigate-21634-dirty-rect

Conversation

@rahul37wallst-sudo

Copy link
Copy Markdown

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Respect disabled emphasis for line-series tooltip hover symbols.

Fixed issues

Details

Before: What was the problem?

For dense canvas line series with showSymbol: false, useDirtyRect: true,
tooltip axis-pointer hover, and emphasis: { disabled: true },
LineView.highlight() could still create a temporary hover symbol.

That temporary symbol was later removed during downplay. The add/remove
lifecycle could leave stale or corrupted line pixels when dirty-rect repainting
was enabled.

This reproduced with the issue's ECharts 6.1.0 canvas scenario:

  • dense line series
  • showSymbol: false
  • progressive
  • piecewise visualMap
  • tooltip trigger: 'axis'
  • tooltip axis pointer
  • useDirtyRect: true
  • emphasis: { disabled: true }

After: How does it behave after the fixing?

When line-series emphasis is disabled, LineView.highlight() no longer creates
or highlights a temporary hover symbol, and downplay() avoids symbol/whole
series downplay work for disabled emphasis.

The existing polyline state transition is kept so dirty-rect invalidation still
clears tooltip axis-pointer updates correctly.

Verified with a pixel-diff harness comparing a dirty-rect chart against a
full-repaint control:

  • native mouse hover: 0 mismatches
  • showTip action: 0 mismatches
  • settled after hideTip: 0 mismatches

Also passed:

npm run lint
npm run checktype

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

Security Checking

  • This PR uses security-sensitive Web APIs.

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Merging options

  • Please squash the commits into a single one when merging.

Other information

This fix was investigated together with ecomfe/zrender#1159. The ZRender
dirty-rect changes improved related behavior but did not fully resolve this
ECharts-side temp-symbol path. The final fix here is independent of ZRender
changes.

@echarts-bot

echarts-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant