fix: update Readme e2e setup to require build:example#166
Open
KapilSachdev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E2E Build Prerequisite Clarification
Following Readme instructions for e2e fails with error
You need to run node tool/build-example.js before run this test.Problem
echarts-examplesREADMEinstructs users to run:so that e2e tests can execute without issues using
However,
build:examplelistinvokestool/build-example.js --no-thumb, which skips the Puppeteer-driven screenshot flow.That also means the option JSON files under
public/data/option/*.jsonare not generated, which invokes below code:echarts-examples/e2e/main.js
Lines 280 to 290 in 37bf026
Solution
npm run build:example