fix: fix nil map panic in CompareConfigmapAndTriggerRestart when dcr.Annotations is nil#493
Open
JinVei wants to merge 1 commit into
Open
fix: fix nil map panic in CompareConfigmapAndTriggerRestart when dcr.Annotations is nil#493JinVei wants to merge 1 commit into
JinVei wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
When
CompareConfigmapAndTriggerRestartdetects a configmap change and triggersa rolling restart, it assigns directly to
dcr.Annotationswithout checkingwhether the map is initialized. If a
DorisClusterCR is created without anyannotations,
dcr.Annotationsis nil, causing a panic that crashes the reconcileloop.
Additionally, a copy-paste bug caused the log line to print
dcr.Namespacetwiceinstead of
dcr.Namefor the CRD name field.Observed error:
Fix:
dcr.Annotationsbefore assignment when it is nil.dcr.Nameinstead ofdcr.Namespacefor the CRD name field.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)