Repository navigation
fix(browser): align test page with Jasmine 5 and remove missing asset refs - #69
Merged
Merged
Conversation
- Add jasmine/boot0.js script tag (required for Jasmine 5.x to initialize window.jasmine global and expose describe/it/expect etc.) - Remove references to bootstrap CSS and JS files that were never included in the package assets (404 errors) and are purely cosmetic
Contributor
Author
|
I tested the actions on apache/cordova-plugin-network-information#184 with this PR and it works now. Can this be merged? |
Contributor
Author
|
If no one has any objections I would merge it |
Member
|
I would suggest not to remove the |
Contributor
Author
|
Ok, I will also improve the documentation for it. I think this is the file which will be injected by |
- `csp-incl.js` will be injected by `cordova-mobile-spec`: https://github.com/apache/cordova-mobile-spec/blob/master/www/csp-incl.js and should not be removed
- Make clear, that this is only injected by `cordova-mobile-spec` and will produce a 404 when not hosted in `cordova-mobile-spec`. - Add link for `csp-incl.js` of `cordova-mobile-spec`
Contributor
Author
I added it back and improved the documentation |
- Document what `boot0.js` is and why only this file is loaded and not additonally `boot1.js`
GitToTheHub
added a commit
to GitToTheHub/cordova-paramedic
that referenced
this pull request
Jun 6, 2026
- PR apache/cordova-plugin-test-framework#69 was merged and the master can now be used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates browser test assets to match the current Jasmine runtime and reduce CI noise.
Changes
jasmine/boot0.jsinwww/assets/index.htmlso Jasmine 5 initializes the global interface expected by the test harness.www/assets/index.htmlthat are not shipped in plugin assets and produced 404s.csp-incl.jscordova-mobile-specand will produce a 404 when not hosted incordova-mobile-spec.csp-incl.jsofcordova-mobile-specMotivation
Without bootstrapping, harness code calling
window.jasmine.getEnv()may fail under Jasmine 5. Missing static references also clutter CI output and obscure actionable failures.Validation
Cross-PR Testing Note
For integration testing purposes, apache/cordova-paramedic#302 installs this PR via
apache/cordova-plugin-test-framework#pull/69/head.Downstream Validation
A dedicated downstream test PR is open in
apache/cordova-plugin-network-information:That PR consumes this change chain and demonstrates successful CI runs.
Generated-By: GPT-5.3-Codex