allow domain suffix update in shared networks

[DaanHoogland]

Description

This PR...

Fixes: #9405

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 15.81%. Comparing base (638c152) to head (074d0d8).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
...ain/java/com/cloud/network/NetworkServiceImpl.java	0.00%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##               main    #9585     +/-   ##
===========================================
  Coverage     15.81%   15.81%             
  Complexity    12539    12539             
===========================================
  Files          5623     5623             
  Lines        491606   491610      +4     
  Branches      59582    63449   +3867     
===========================================
+ Hits          77725    77735     +10     
+ Misses       405562   405555      -7     
- Partials       8319     8320      +1     

Flag	Coverage Δ
uitests	4.49% <ø> (-0.01%)	⬇️
unittests	16.60% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10783

[DaanHoogland]

@blueorangutan test keepEnv securityGroups

[DaanHoogland]

@blueorangutan test keepEnv

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[DaanHoogland]

@blueorangutan test keepEnv securityGroups

[blueorangutan]

[SF] Trillian test result (tid-11176)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57074 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9585-t11176-kvm-ol8.zip
Smoke tests completed. 139 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[DaanHoogland]

needs the following (but on hold now) : test in advanced zone with security groups, add UI part, check question by @weizhouapache in #9585 (comment) (and probably more)

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11007

[blueorangutan]

[LL]Trillian test result (tid-7016)
Environment: kvm-alma8 (x2), Advanced Networking with Mgmt server a8
Total time taken: 50402 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9585-t7016-kvm-alma8.zip
Smoke tests completed. 139 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_mount_shared_fs	Failure	93.86	test_sharedfs_lifecycle.py
test_resize_shared_fs	Error	0.23	test_sharedfs_lifecycle.py

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11056

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11060

[DaanHoogland]

@blueorangutan test keepEnv securityGroups

[weizhouapache]

lgtm

tried to update the network domain a shared network

• prior to this PR, it failed
• with this PR, it succeeded. VR is restarted. it has correct configuration in /etc/dnsmasq.conf
• VM (without reboot) got new full hostname and correct /etc/resolv.conf after dhclient
  

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 11079

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11084

[DaanHoogland]

@blueorangutan LLtest keepEnv securityGroups

[blueorangutan]

@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[rajujith]

LGTM
Tested updating the domain name, it works now.